Messages in this thread | | | Subject | Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver | From | Jie Deng <> | Date | Thu, 15 Apr 2021 14:56:19 +0800 |
| |
On 2021/4/15 14:45, Viresh Kumar wrote: > On 23-03-21, 10:27, Arnd Bergmann wrote: >> I usually recommend the use of __maybe_unused for the suspend/resume >> callbacks for drivers that use SIMPLE_DEV_PM_OPS() or similar helpers >> that hide the exact conditions under which the functions get called. >> >> In this driver, there is an explicit #ifdef in the reference to the >> functions, so >> it would make sense to use the same #ifdef around the definition. > Jie, > > I was talking about this comment when I said I was expecting a new > version. I think you still need to make this change.
I didn't forget this. It is a very small change. I'm not sure if the maintainer Wolfram
has any comments so that I can address them together in one version.
Thanks.
| |