lkml.org 
[lkml]   [2021]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 30/57] staging: rtl8723bs: core: rtw_ieee80211: Remove seemingly pointless copy
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/staging/rtl8723bs/core/rtw_ieee80211.c: In function ‘rtw_ies_remove_ie’:
    drivers/staging/rtl8723bs/core/rtw_ieee80211.c:259:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]

    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: linux-staging@lists.linux.dev
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
    index ae057eefeeb36..d8513acf4911c 100644
    --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
    +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
    @@ -239,12 +239,10 @@ int rtw_ies_remove_ie(u8 *ies, uint *ies_len, uint offset, u8 eid, u8 *oui, u8 o
    while (1) {
    target_ie = rtw_get_ie_ex(start, search_len, eid, oui, oui_len, NULL, &target_ielen);
    if (target_ie && target_ielen) {
    - u8 buf[MAX_IE_SZ] = {0};
    u8 *remain_ies = target_ie + target_ielen;
    uint remain_len = search_len - (remain_ies - start);

    - memcpy(buf, remain_ies, remain_len);
    - memcpy(target_ie, buf, remain_len);
    + memcpy(target_ie, remain_ies, remain_len);
    *ies_len = *ies_len - target_ielen;
    ret = _SUCCESS;

    --
    2.27.0
    \
     
     \ /
      Last update: 2021-04-14 20:14    [W:4.217 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site