lkml.org 
[lkml]   [2021]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on DBG_871X removal sites
On Wed, Apr 07, 2021 at 03:49:36PM +0200, Fabio Aiuto wrote:
> @@ -2586,11 +2583,9 @@ static int rtw_dbg_port(struct net_device *dev,
>
> plist = get_next(plist);
>
> - if (extra_arg == psta->aid) {
> - for (j = 0; j < 16; j++) {
> + if (extra_arg == psta->aid)
> + for (j = 0; j < 16; j++)
> preorder_ctrl = &psta->recvreorder_ctrl[j];
> - }
> - }

I think Greg already applied this so no stress (don't bother fixing),
but you removed a bit too much on this one. Multi-line indents normally
get curly braces for readability. In other words:

if (extra_arg == psta->aid) {
for (j = 0; j < 16; j++)
preorder_ctrl = &psta->recvreorder_ctrl[j];
}

regards,
dan carpenter

\
 
 \ /
  Last update: 2021-04-13 16:55    [W:0.206 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site