lkml.org 
[lkml]   [2021]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface
Date
From: SeongJae Park <sjpark@amazon.de>

On Sat, 10 Apr 2021 10:55:01 +0200 Greg KH <greg@kroah.com> wrote:

> On Thu, Apr 08, 2021 at 01:48:48PM +0000, SeongJae Park wrote:
> > +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx)
> > +{
> > + const char * const file_names[] = {"attrs", "target_ids"};
> > + const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops};
> > + int i;
> > +
> > + for (i = 0; i < ARRAY_SIZE(file_names); i++)
> > + debugfs_create_file(file_names[i], 0600, dir, ctx, fops[i]);
> > +
> > + return 0;
> > +}
>
> Why do you have a function that can only return 0, actually return
> something? It should be void, right?

You're right, I will make it return void in the next spin.


Thanks,
SeongJae Park

>
> thanks,
>
> greg k-h
>

\
 
 \ /
  Last update: 2021-04-10 12:58    [W:1.088 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site