Messages in this thread | | | Subject | Re: [PATCH RESEND 0/3] x86/sgx: eextend ioctl | From | Jethro Beekman <> | Date | Thu, 1 Apr 2021 19:59:07 +0200 |
| |
On 2021-04-01 18:11, Dave Hansen wrote: > On 4/1/21 7:56 AM, Raoul Strackx wrote: >> >> SOLUTION OF THIS PATCH >> This patch adds a new ioctl to enable userspace to execute EEXTEND leaf >> functions per 256 bytes of enclave memory. This enables enclaves to be >> build as specified by enclave providers. > > I think tying the user ABI to the SGX architecture this closely is a > mistake. > > Do we need another ioctl() or can we just relax the existing add_pages > ioctl() to allow unaligned addresses? >
Some version of the driver used to pass a 16-bit bitset of which of the 16 256-byte parts of a 4096-byte page to measure. This was removed at some point in favor of a separate ioctl to be added later. That is this. See the discussion linked in the cover letter.
-- Jethro Beekman | Fortanix
[unhandled content-type:application/pkcs7-signature] | |