Messages in this thread | | | Subject | Re: [PATCH v2 2/2] KVM: nSVM: improve SYSENTER emulation on AMD | From | Paolo Bonzini <> | Date | Thu, 1 Apr 2021 17:57:33 +0200 |
| |
On 01/04/21 17:31, Vitaly Kuznetsov wrote: >>>> + svm->sysenter_eip_hi = guest_cpuid_is_intel(vcpu) ? (data >> 32) : 0; >>> (Personal taste) I'd suggest we keep the whole 'sysenter_eip'/'sysenter_esp' >>> even if we only use the upper 32 bits of it. That would reduce the code >>> churn a little bit (no need to change 'struct vcpu_svm'). >> Would there really be less changes? Consider that you'd have to look at >> the VMCB anyway because svm_get_msr can be reached not just for guest >> RDMSR but also for ioctls. >> > I was thinking about the hunk in arch/x86/kvm/svm/svm.h tweaking > vcpu_svm. My opinion is not strong at all here)
Ah okay, if it's just that I would consider the change a benefit, not a problem with this patch.
Paolo
| |