Messages in this thread | | | Date | Thu, 1 Apr 2021 08:35:48 +0200 | From | Krzysztof Wilczyński <> | Subject | Re: [PATCH v4 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver |
| |
Hi Greentime,
[...] > + /* Wait for wait_idle */ > + ret = readl_poll_timeout(phy_cr_para_ack, val, val, 10, 5000); > + if (ret) > + dev_err(dev, "Wait for wait_ilde state failed!\n"); > + > + /* Clear */ > + writel_relaxed(0, phy_cr_para_wr_en); > + > + /* Wait for ~wait_idle */ > + ret = readl_poll_timeout(phy_cr_para_ack, val, !val, 10, 5000); > + if (ret) > + dev_err(dev, "Wait for !wait_ilde state failed!\n"); > +} [...] > +static int fu740_pcie_start_link(struct dw_pcie *pci) > +{ > + struct device *dev = pci->dev; > + > + /* Start LTSSM. */ > + fu740_pcie_ltssm_enable(dev); > + return 0; > +}
The typos etc., are still here. See:
https://lore.kernel.org/linux-pci/YFQqpojmJyX0l6lx@rocinante/
Krzysztof
| |