Messages in this thread | | | Subject | [PATCH v4 0/4] cxl/mem: Fix memdev device setup | From | Dan Williams <> | Date | Thu, 01 Apr 2021 07:33:09 -0700 |
| |
Changes since v3 [1]:
- Drop cxl_memdev_activate(). An open-coded pointer assignment is sufficient relative to cdev_device_add() publishing the device (Jason)
[1]: http://lore.kernel.org/r/161714738634.2168142.10860201861152789544.stgit@dwillia2-desk3.amr.corp.intel.com
---
A collection of fixes initially inspired by Jason's recognition of dev_set_name() error handling mistakes on other driver review, but also from a deeper discussion of idiomatic device operation shutdown flows. The end result is easier to reason about and validate. Thank you, Jason.
The sysfs_emit() fixup and unpublishing of device power management files are independent sanity cleanups.
---
Dan Williams (4): cxl/mem: Use sysfs_emit() for attribute show routines cxl/mem: Fix synchronization mechanism for device removal vs ioctl operations cxl/mem: Do not rely on device_add() side effects for dev_set_name() failures cxl/mem: Disable cxl device power management
drivers/cxl/mem.c | 141 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 82 insertions(+), 59 deletions(-)
base-commit: a38fd8748464831584a19438cbb3082b5a2dab15
| |