lkml.org 
[lkml]   [2021]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 13/13] KVM: x86/mmu: Tear down roots in fast invalidation thread
From
Date
On 01/04/21 00:29, Sean Christopherson wrote:
>> + if (is_tdp_mmu_enabled(kvm)) {
>> + read_lock(&kvm->mmu_lock);
>> + kvm_tdp_mmu_zap_all_fast(kvm);
> Purely because it exists first, I think we should follow the legacy MMU's
> terminology, i.e. kvm_tdp_mmu_zap_obsolete_pages().
>

It's a bit different, obsolete pages in kvm_zap_obsolete_pages have an
old mmu_valid_gen. They are not invalid, so it is inaccurate to talk
about obsolete pages in the context of the TDP MMU. But I agree that
the function should be renamed.

Paolo

\
 
 \ /
  Last update: 2021-04-01 12:42    [W:0.073 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site