Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 1 Apr 2021 12:24:50 +0300 | Subject | Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__ |
| |
On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan <dmugil2000@gmail.com> wrote: > > Change function's name to %s and __func__ to fix checkpatch.pl errors.
No, just drop the __func__ completely. First of all, we have a device name, and uniqueness of the messages in the driver should guarantee easy findings. Second, specific to _dbg() variants, with enabled Dynamic Debug it can be chosen at run time!
I recommend going through all drivers and drop __func__ near to dev_dbg() and pr_debug().
-- With Best Regards, Andy Shevchenko
| |