Messages in this thread | | | From | Namhyung Kim <> | Date | Thu, 1 Apr 2021 16:19:38 +0900 | Subject | Re: [PATCH] tools: perf: util: Remove duplicate struct declaration |
| |
Hello,
On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing <wanjiabing@vivo.com> wrote: > > struct target is declared twice. One has been declared > at 21st line. Remove the duplicate. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
I think we can move all the forward declarations to the top (and sort them) as well.
Thanks, Namhyung
> --- > tools/perf/util/evsel.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h > index 6026487353dd..998e5b806696 100644 > --- a/tools/perf/util/evsel.h > +++ b/tools/perf/util/evsel.h > @@ -157,7 +157,6 @@ struct perf_missing_features { > extern struct perf_missing_features perf_missing_features; > > struct perf_cpu_map; > -struct target; > struct thread_map; > struct record_opts; > > -- > 2.25.1 >
| |