Messages in this thread | | | Date | Fri, 2 Apr 2021 06:21:49 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH] arm64/kernel/probes: Use BUG_ON instead of if condition followed by BUG. |
| |
On Tue, 30 Mar 2021 04:57:50 -0700 zhouchuangao <zhouchuangao@vivo.com> wrote:
> It can be optimized at compile time. >
Anyway, this seems to make the code simpler.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> Signed-off-by: zhouchuangao <zhouchuangao@vivo.com> > --- > arch/arm64/kernel/probes/kprobes.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c > index 66aac28..ecf0f61 100644 > --- a/arch/arm64/kernel/probes/kprobes.c > +++ b/arch/arm64/kernel/probes/kprobes.c > @@ -264,8 +264,7 @@ int __kprobes kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr) > * normal page fault. > */ > instruction_pointer_set(regs, (unsigned long) cur->addr); > - if (!instruction_pointer(regs)) > - BUG(); > + BUG_ON(!instruction_pointer(regs)); > > if (kcb->kprobe_status == KPROBE_REENTER) > restore_previous_kprobe(kcb); > -- > 2.7.4 >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |