lkml.org 
[lkml]   [2021]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] x86/sgx: Add sgx_nr_{all, free}_pages to the debugfs
From
Date
On 3/31/21 10:21 PM, Jarkko Sakkinen wrote:
> +#ifdef CONFIG_DEBUG_FS
> + debugfs_create_file("sgx_nr_all_pages", 0400, arch_debugfs_dir, NULL,
> + &sgx_nr_all_pages_fops);
> + debugfs_create_file("sgx_nr_free_pages", 0400, arch_debugfs_dir, NULL,
> + &sgx_nr_free_pages_fops);
> +#endif /* CONFIG_DEBUG_FS */


Why not make the types u64's and use debugfs_create_u64()? That would
save a ton of code. There's also debugfs_create_ulong().

\
 
 \ /
  Last update: 2021-04-01 21:34    [W:0.261 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site