Messages in this thread | | | From | Nick Desaulniers <> | Date | Thu, 1 Apr 2021 11:55:49 -0700 | Subject | Re: [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power |
| |
On Thu, Apr 1, 2021 at 9:05 AM Maciej Falkowski <maciej.falkowski9@gmail.com> wrote: > > The ams_delta_camera_power() function is unused as reports > Clang compilation with omap1_defconfig on linux-next: > > arch/arm/mach-omap1/board-ams-delta.c:462:12: warning: unused function 'ams_delta_camera_power' [-Wunused-function] > static int ams_delta_camera_power(struct device *dev, int power) > ^ > 1 warning generated. > > The soc_camera support was dropped without removing > ams_delta_camera_power() function, making it unused. > > Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Fixes: ce548396a433 ("media: mach-omap1: board-ams-delta.c: remove soc_camera dependencies") > Link: https://github.com/ClangBuiltLinux/linux/issues/1326 > --- > arch/arm/mach-omap1/board-ams-delta.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c > index 2ee527c00284..1026a816dcc0 100644 > --- a/arch/arm/mach-omap1/board-ams-delta.c > +++ b/arch/arm/mach-omap1/board-ams-delta.c > @@ -458,20 +458,6 @@ static struct gpiod_lookup_table leds_gpio_table = { > > #ifdef CONFIG_LEDS_TRIGGERS > DEFINE_LED_TRIGGER(ams_delta_camera_led_trigger); > - > -static int ams_delta_camera_power(struct device *dev, int power) > -{ > - /* > - * turn on camera LED > - */ > - if (power) > - led_trigger_event(ams_delta_camera_led_trigger, LED_FULL); > - else > - led_trigger_event(ams_delta_camera_led_trigger, LED_OFF); > - return 0; > -} > -#else > -#define ams_delta_camera_power NULL > #endif > > static struct platform_device ams_delta_audio_device = { > -- > 2.26.3 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210401160434.7655-1-maciej.falkowski9%40gmail.com.
-- Thanks, ~Nick Desaulniers
| |