lkml.org 
[lkml]   [2021]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: core: Don't set platform name when of_node is set
On Tue, Mar 09, 2021 at 10:23:28AM +0200, Daniel Baluta wrote:
> From: Daniel Baluta <daniel.baluta@nxp.com>
>
> Platform may be specified by either name or OF node but not
> both.
>
> For OF node platforms (e.g i.MX) we end up with both platform name
> and of_node set and sound card registration will fail with the error:
>
> asoc-simple-card sof-sound-wm8960: ASoC: Neither/both
> platform name/of_node are set for sai1-wm8960-hifi

This doesn't actually say what the change does.

> - dai_link->platforms->name = component->name;
> +
> + if (!dai_link->platforms->of_node)
> + dai_link->platforms->name = component->name;

Why would we prefer the node name over something explicitly configured?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-03-09 16:37    [W:0.139 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site