Messages in this thread | | | Date | Tue, 9 Mar 2021 09:29:23 +0300 | From | Dan Carpenter <> | Subject | Re: Re: [PATCH] Input: elan_i2c - Reduce the resume time for new dev ices |
| |
Hi 'Dmitry,
url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/Re-PATCH-Input-elan_i2c-Reduce-the-resume-time-for-new-dev-ices/20210308-111956 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: x86_64-randconfig-m001-20210308 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings: drivers/input/mouse/elan_i2c_core.c:122 elan_i2c_lookup_quirks() warn: ignoring unreachable code.
vim +122 drivers/input/mouse/elan_i2c_core.c
5b1301343b8d29 Dmitry Torokhov 2021-03-07 100 static u32 elan_i2c_lookup_quirks(u16 ic_type, u16 product_id) 5b1301343b8d29 Dmitry Torokhov 2021-03-07 101 { 5b1301343b8d29 Dmitry Torokhov 2021-03-07 102 static const struct { 5b1301343b8d29 Dmitry Torokhov 2021-03-07 103 u16 ic_type; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 104 u16 product_id; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 105 u32 quirks; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 106 } elan_i2c_quirks[] = { 5b1301343b8d29 Dmitry Torokhov 2021-03-07 107 { 0x0D, ETP_PRODUCT_ID_DELBIN, ETP_QUIRK_QUICK_WAKEUP }, 5b1301343b8d29 Dmitry Torokhov 2021-03-07 108 { 0x10, ETP_PRODUCT_ID_VOXEL, ETP_QUIRK_QUICK_WAKEUP }, 5b1301343b8d29 Dmitry Torokhov 2021-03-07 109 { 0x14, ETP_PRODUCT_ID_MAGPIE, ETP_QUIRK_QUICK_WAKEUP }, 5b1301343b8d29 Dmitry Torokhov 2021-03-07 110 { 0x14, ETP_PRODUCT_ID_BOBBA, ETP_QUIRK_QUICK_WAKEUP }, 6696777c6506fa Duson Lin 2014-10-03 111 }; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 112 u32 quirks = 0; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 113 int i; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 114 5b1301343b8d29 Dmitry Torokhov 2021-03-07 115 for (i = 0; ARRAY_SIZE(elan_i2c_quirks); i++) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^ The "i < " part of this condition is missing.
5b1301343b8d29 Dmitry Torokhov 2021-03-07 116 if (elan_i2c_quirks[i].ic_type == ic_type && 5b1301343b8d29 Dmitry Torokhov 2021-03-07 117 elan_i2c_quirks[i].product_id == product_id) { 5b1301343b8d29 Dmitry Torokhov 2021-03-07 118 quirks = elan_i2c_quirks[i].quirks; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 119 } 5b1301343b8d29 Dmitry Torokhov 2021-03-07 120 } 5b1301343b8d29 Dmitry Torokhov 2021-03-07 121 5b1301343b8d29 Dmitry Torokhov 2021-03-07 @122 if (ic_type >= 0x0D && product_id >= 0x123) 5b1301343b8d29 Dmitry Torokhov 2021-03-07 123 quirks |= ETP_QUIRK_QUICK_WAKEUP; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 124 5b1301343b8d29 Dmitry Torokhov 2021-03-07 125 return quirks; 5b1301343b8d29 Dmitry Torokhov 2021-03-07 126 }
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |