Messages in this thread | | | Subject | Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional | From | Chanwoo Choi <> | Date | Tue, 9 Mar 2021 19:11:19 +0900 |
| |
Hi Krzysztof,
On 3/9/21 1:11 AM, Krzysztof Kozlowski wrote: > On Mon, 8 Mar 2021 at 17:02, Arnd Bergmann <arnd@kernel.org> wrote: >> >> On Mon, Mar 8, 2021 at 4:33 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >>> >>> On 08/03/2021 16:29, Arnd Bergmann wrote: >>>> From: Arnd Bergmann <arnd@arndb.de> >>>> >>>> Some of the extcon interfaces have a fallback implementation that can >>>> be used when EXTCON is disabled, but some others do not, causing a >>>> build failure: >>>> >>>> drivers/power/supply/max8997_charger.c:261:9: error: implicit declaration of function 'devm_extcon_register_notifier_all' [-Werror,-Wimplicit-function-declaration] >>>> ret = devm_extcon_register_notifier_all(&pdev->dev, charger->edev, >>>> ^ >>>> drivers/power/supply/max8997_charger.c:261:9: note: did you mean 'devm_extcon_register_notifier'? >>>> include/linux/extcon.h:263:19: note: 'devm_extcon_register_notifier' declared here >>>> static inline int devm_extcon_register_notifier(struct device *dev, >>>> >>>> I assume there is no reason to actually build this driver without extcon >>>> support, so a hard dependency is the easiest fix. Alternatively the >>>> header file could be extended to provide additional inline stubs. >>> >>> Hi Arnd, >>> >>> Thanks for the patch but I think I got it covered with: >>> https://lore.kernel.org/lkml/20210215100610.19911-2-cw00.choi@samsung.com/ >>> (sent via extcon tree). >>> >>> Did you experience a new/different issue? >> >> The patch should be fine and address the problem, I just didn't see it was >> already fixed in linux-next as I'm still testing on mainline (rc2 at >> the moment). >> >> I assume the fix will make it into a future -rc then. > > It's still only in linux-next via extcon tree, so it seems Greg did > not take it yet. > > Chanwoo, > You might need to follow up on this, so your pull request won't get lost.
I'm sorry. Because of my fault, the previous pull request was not merged to v5.12-rc1. To fix this issue, I'll send the pull request for rc3 to Greg.
Best Regards, Chanwoo Choi Samsung Electronics
| |