Messages in this thread | | | From | Georgi Djakov <> | Subject | Re: [PATCH] mm/slub: Add slub_debug option to panic on memory corruption | Date | Tue, 9 Mar 2021 20:14:30 +0200 |
| |
Hi Vlastimil,
Thanks for the comment!
On 3/9/21 17:09, Vlastimil Babka wrote: > On 3/9/21 2:47 PM, Georgi Djakov wrote: >> Being able to stop the system immediately when a memory corruption >> is detected is crucial to finding the source of it. This is very >> useful when the memory can be inspected with kdump or other tools. > > Is this in some testing scenarios where you would also use e.g. panic_on_warn? > We could hook to that. If not, we could introduce a new > panic_on_memory_corruption that would apply also for debug_pagealloc and whatnot?
I would prefer that we not tie it with panic_on_warn - there might be lots of new code in multiple subsystems, so hitting some WARNing while testing is not something unexpected.
Introducing an additional panic_on_memory_corruption would work, but i noticed that we already have slub_debug and thought to re-use that. But indeed, аdding an option to panic in for example bad_page() sounds also useful, if that's what you suggest.
Thanks, Georgi
| |