Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 8 Mar 2021 16:57:35 +0200 | Subject | Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio |
| |
On Mon, Mar 8, 2021 at 4:11 PM Calvin Johnson <calvin.johnson@oss.nxp.com> wrote: > On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson > > <calvin.johnson@oss.nxp.com> wrote:
> > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > > > each ACPI child node. > > > > > +#include <linux/acpi.h> > > > +#include <linux/acpi_mdio.h> > > > > Perhaps it's better to provide the headers that this file is direct > > user of, i.e. > > bits.h > > dev_printk.h > > Looks like device.h needs to be used instead of dev_printk.h. Please > let me know if you've a different opinion.
I don't see the user of device.h. dev_printk.h is definitely in use here... Do you see a user for device.h? Which line in your code requires it?
It might be that I don't see something quite obvious...
> > module.h > > types.h > > > > The rest seems fine because they are guaranteed to be included by > > acpi.h (IIUC about fwnode API and acpi_mdio includes MDIO PHY APIs).
-- With Best Regards, Andy Shevchenko
| |