Messages in this thread | | | Date | Mon, 8 Mar 2021 19:37:51 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] block: Suppress uevent for hidden device when removed |
| |
On Wed, Mar 03, 2021 at 06:30:34PM +0100, Martin Wilck wrote: > I wonder if it wouldn't be wiser to remove this code > > if (disk->flags & GENHD_FL_HIDDEN) { > dev_set_uevent_suppress(ddev, 0); > return; > } > > from register_disk(). The way you did it now, we would receive neither > "add" nor "remove" events in user space, but there might be change > events in between ?
Well, we'll need to keep the return. That being said keepign the uevents supressed entirely might be a good idea.
| |