Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang | Date | Fri, 05 Mar 2021 15:40:33 +0200 |
| |
"Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix > multiple warnings by replacing /* fall through */ comments with > the new pseudo-keyword macro fallthrough; instead of letting the > code fall through to the next case. > > Notice that Clang doesn't recognize /* fall through */ comments as > implicit fall-through markings. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
It's not cool that you ignore the comments you got in [1], then after a while mark the patch as "RESEND" and not even include a changelog why it was resent.
[1] https://patchwork.kernel.org/project/linux-wireless/patch/d522f387b2d0dde774785c7169c1f25aa529989d.1605896060.git.gustavoars@kernel.org/
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |