Messages in this thread | | | Subject | Re: [PATCH v4 07/13] phy: cadence: cadence-sierra: Explicitly request exclusive reset control | From | Philipp Zabel <> | Date | Thu, 04 Mar 2021 12:54:54 +0100 |
| |
On Thu, 2021-03-04 at 10:11 +0530, Kishon Vijay Abraham I wrote: > No functional change. Since the reset controls obtained in > Sierra is exclusively used by the Sierra device, use > exclusive reset control request API calls. > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/phy/cadence/phy-cadence-sierra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c > index 935f165404e4..44c52a0842dc 100644 > --- a/drivers/phy/cadence/phy-cadence-sierra.c > +++ b/drivers/phy/cadence/phy-cadence-sierra.c > @@ -514,14 +514,14 @@ static int cdns_sierra_phy_get_resets(struct cdns_sierra_phy *sp, > { > struct reset_control *rst; > > - rst = devm_reset_control_get(dev, "sierra_reset"); > + rst = devm_reset_control_get_exclusive(dev, "sierra_reset"); > if (IS_ERR(rst)) { > dev_err(dev, "failed to get reset\n"); > return PTR_ERR(rst); > } > sp->phy_rst = rst; > > - rst = devm_reset_control_get_optional(dev, "sierra_apb"); > + rst = devm_reset_control_get_optional_exclusive(dev, "sierra_apb"); > if (IS_ERR(rst)) { > dev_err(dev, "failed to get apb reset\n"); > return PTR_ERR(rst);
Oh, nevermind my comment on the previous patch.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards Philipp
| |