lkml.org 
[lkml]   [2021]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] mm: cma: support sysfs
On Wed, 3 Mar 2021 17:38:12 -0800 Minchan Kim <minchan@kernel.org> wrote:

> > > #endif
> > > char name[CMA_MAX_NAME];
> > > +#ifdef CONFIG_CMA_SYSFS
> > > + struct cma_stat *stat;
> > > +#endif
> > > };
> >
> > Why aren't the stat fields simply placed directly into struct cma_stat?
>
> It have a related long discussion.
> https://lore.kernel.org/linux-mm/YCIoHBGELFWAyfMi@kroah.com/
> https://lore.kernel.org/linux-mm/YCLLKDEQ4NYqb5Y5@kroah.com/
>
> TLDR - Greg really want to see kobject stuff working as dynamic
> property.

Please add to changelog?

> >
> > ?
> >
> > > + if (!cma_stats) {
> > > + pr_err("failed to create cma_stats\n");
> >
> > Probably unneeded - the ENOMEM stack backtrace will point straight here.
>
> I failed to find the point you mentioned to print backtrace.
> Where code do you mean to dump the backtrace?

The thing which __GFP_NOWARN disables.

\
 
 \ /
  Last update: 2021-03-04 07:12    [W:0.071 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site