lkml.org 
[lkml]   [2021]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 112/141] net: rose: Fix fall-through warnings for Clang
    Hi all,

    It's been more than 3 months; who can take this, please? :)

    Thanks
    --
    Gustavo

    On Fri, Nov 20, 2020 at 12:38:32PM -0600, Gustavo A. R. Silva wrote:
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    > warnings by explicitly adding multiple break statements instead of
    > letting the code fall through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    > ---
    > net/rose/rose_route.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
    > index 6e35703ff353..c0e04c261a15 100644
    > --- a/net/rose/rose_route.c
    > +++ b/net/rose/rose_route.c
    > @@ -347,6 +347,7 @@ static int rose_del_node(struct rose_route_struct *rose_route,
    > case 1:
    > rose_node->neighbour[1] =
    > rose_node->neighbour[2];
    > + break;
    > case 2:
    > break;
    > }
    > @@ -508,6 +509,7 @@ void rose_rt_device_down(struct net_device *dev)
    > fallthrough;
    > case 1:
    > t->neighbour[1] = t->neighbour[2];
    > + break;
    > case 2:
    > break;
    > }
    > --
    > 2.27.0
    >

    \
     
     \ /
      Last update: 2021-03-05 00:01    [W:7.803 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site