Messages in this thread | | | Date | Tue, 2 Mar 2021 17:24:56 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 10/13] rcu/nocb: Delete bypass_timer upon nocb_gp wakeup |
| |
On Tue, Feb 23, 2021 at 01:10:08AM +0100, Frederic Weisbecker wrote: > A NOCB-gp wake up can safely delete the nocb_bypass_timer. nocb_gp_wait() > is going to check again the bypass state and rearm the bypass timer if > necessary. > > Signed-off-by: Frederic Weisbecker <frederic@kernel.org> > Cc: Josh Triplett <josh@joshtriplett.org> > Cc: Lai Jiangshan <jiangshanlai@gmail.com> > Cc: Joel Fernandes <joel@joelfernandes.org> > Cc: Neeraj Upadhyay <neeraju@codeaurora.org> > Cc: Boqun Feng <boqun.feng@gmail.com>
Give that you delete this code a couple of patches later in this series, why not just leave it out entirely? ;-)
Thanx, Paul
> --- > kernel/rcu/tree_plugin.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h > index b62ad79bbda5..9da67b0d3997 100644 > --- a/kernel/rcu/tree_plugin.h > +++ b/kernel/rcu/tree_plugin.h > @@ -1711,6 +1711,8 @@ static bool __wake_nocb_gp(struct rcu_data *rdp_gp, > del_timer(&rdp_gp->nocb_timer); > } > > + del_timer(&rdp_gp->nocb_bypass_timer); > + > if (force || READ_ONCE(rdp_gp->nocb_gp_sleep)) { > WRITE_ONCE(rdp_gp->nocb_gp_sleep, false); > needwake = true; > -- > 2.25.1 >
| |