lkml.org 
[lkml]   [2021]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 176/221] octeontx2-af: Fix memory leak of object buf
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 9e0a537d06fc36861e4f78d0a7df1fe2b3592714 ]

    Currently the error return path when lfs fails to allocate is not free'ing
    the memory allocated to buf. Fix this by adding the missing kfree.

    Addresses-Coverity: ("Resource leak")
    Fixes: f7884097141b ("octeontx2-af: Formatting debugfs entry rsrc_alloc.")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Acked-by: Sunil Goutham <sgoutham@marvell.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
    index c018121d4cc5..bc870bff14df 100644
    --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
    +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
    @@ -163,8 +163,10 @@ static ssize_t rvu_dbg_rsrc_attach_status(struct file *filp,
    return -ENOSPC;

    lfs = kzalloc(lf_str_size, GFP_KERNEL);
    - if (!lfs)
    + if (!lfs) {
    + kfree(buf);
    return -ENOMEM;
    + }
    off += scnprintf(&buf[off], buf_size - 1 - off, "%-*s", lf_str_size,
    "pcifunc");
    for (index = 0; index < BLK_COUNT; index++)
    --
    2.30.1


    \
     
     \ /
      Last update: 2021-03-29 10:47    [W:4.214 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site