lkml.org 
[lkml]   [2021]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 121/221] net: phylink: Fix phylink_err() function name error in phylink_major_config
    Date
    From: Ong Boon Leong <boon.leong.ong@intel.com>

    [ Upstream commit d82c6c1aaccd2877b6082cebcb1746a13648a16d ]

    if pl->mac_ops->mac_finish() failed, phylink_err should use
    "mac_finish" instead of "mac_prepare".

    Fixes: b7ad14c2fe2d4 ("net: phylink: re-implement interface configuration with PCS")
    Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/phy/phylink.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
    index fe2296fdda19..6072e87ed6c3 100644
    --- a/drivers/net/phy/phylink.c
    +++ b/drivers/net/phy/phylink.c
    @@ -472,7 +472,7 @@ static void phylink_major_config(struct phylink *pl, bool restart,
    err = pl->mac_ops->mac_finish(pl->config, pl->cur_link_an_mode,
    state->interface);
    if (err < 0)
    - phylink_err(pl, "mac_prepare failed: %pe\n",
    + phylink_err(pl, "mac_finish failed: %pe\n",
    ERR_PTR(err));
    }
    }
    --
    2.30.1


    \
     
     \ /
      Last update: 2021-03-29 10:36    [W:4.086 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site