Messages in this thread | | | From | "Martin K. Petersen" <> | Subject | Re: [PATCH] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust | Date | Mon, 29 Mar 2021 23:54:37 -0400 |
| |
On Wed, 10 Mar 2021 23:16:02 +0100, Rasmus Villemoes wrote:
> Instead of strcpy'ing into a stack buffer, just let additional_notice > point to a string literal living in .rodata. This is better in a few > ways: > > - Smaller .text - instead of gcc compiling the strcpys as a bunch of > immediate stores (effectively encoding the string literal in the > instruction stream), we only pay the price of storing the literal in > .rodata. > > [...]
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust https://git.kernel.org/mkp/scsi/c/adb253433dc8
-- Martin K. Petersen Oracle Linux Engineering
| |