lkml.org 
[lkml]   [2021]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk
    Hi Adam,

    On Mon, Mar 29, 2021 at 2:45 PM Adam Ford <aford173@gmail.com> wrote:
    > On Thu, Mar 4, 2021 at 2:08 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
    > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford <aford173@gmail.com> wrote:
    > > > For devices that use a programmable clock for the AVB reference clock,
    > > > the driver may need to enable them. Add code to find the optional clock
    > > > and enable it when available.
    > > >
    > > > Signed-off-by: Adam Ford <aford173@gmail.com>
    > >
    > > Thanks for your patch!
    > >
    > > > --- a/drivers/net/ethernet/renesas/ravb_main.c
    > > > +++ b/drivers/net/ethernet/renesas/ravb_main.c
    > > > @@ -2148,6 +2148,13 @@ static int ravb_probe(struct platform_device *pdev)
    > > > goto out_release;
    > > > }
    > > >
    > > > + priv->refclk = devm_clk_get_optional(&pdev->dev, "refclk");
    > > > + if (IS_ERR(priv->refclk)) {
    > > > + error = PTR_ERR(priv->refclk);
    > > > + goto out_release;
    > > > + }
    > > > + clk_prepare_enable(priv->refclk);
    > > > +
    > >
    > > Shouldn't the reference clock be disabled in case of any failure below?
    > >
    > I'll generate a V4.
    >
    > Should I just regenerate this patch since it seems like the rest are
    > OK, or should I regenerate the whole series?

    As the DT bindings haven't been applied yet, I think it would be
    best if you would send a v4 with just the patches for the netdev
    tree (i.e. DT bindings patch 1 and driver patch 4).

    I will take the DT patches from this series, once the bindings have been
    accepted.

    Thank you!

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2021-03-29 15:10    [W:5.074 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site