Messages in this thread | | | Date | Mon, 29 Mar 2021 11:55:24 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH resend 2/8] sched: core scheduling tagging infrastructure |
| |
On Fri, Mar 26, 2021 at 08:19:57PM -0700, Josh Don wrote: > On Fri, Mar 26, 2021 at 5:10 PM Peter Zijlstra <peterz@infradead.org> wrote:
> > I've spend the past few hours rewriting patches #2 and #3, and adapting > > #4. The thing was working before I added SHARE_FROM back and introduced > > GET, but now I'm seeing a few FAILs from the selftest. > > > > I'm too tired to make sense of anything much, or even focus my eyes > > consistently, so I'll have to prod at it some more next week, but I've > > pushed out the lot to my queue.git: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=sched/core-sched > > Thanks, I'll take a look next week.
OK, fixed the fails. My tired head made it unconditionally return the cookie-id of 'current' instead of task. Pushed out an update.
> > Also, we really need a better name than coretag.c. > > Yea, we don't really otherwise use the phrase "tagging". core_sched.c > is probably too confusing given we have sched/core.c.
Right, so I tried core_sched and my fingers already hate it as much as kernel/scftorture.c (which I'd assumed my fingers would get used to eventually, but noooo).
Looking at kernel/sched/ C is very overrepresented, so we really don't want another I think. B, E, G, H, J, K, N, seem to still be available in the first half of the alphabet. Maybe, bonghits.c, gabbleduck.c ?
| |