Messages in this thread | | | Date | Sun, 28 Mar 2021 12:12:15 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig |
| |
On Sun, Mar 28, 2021 at 03:59:29PM +0900, Masahiro Yamada wrote: > On Fri, Mar 26, 2021 at 11:36 PM Catalin Marinas > <catalin.marinas@arm.com> wrote: > > On Wed, Mar 24, 2021 at 04:11:28PM +0900, Masahiro Yamada wrote: > > > $(call ld-option, --fix-cortex-a53-843419) in arch/arm64/Makefile is > > > evaluated every time even for Make targets that do not need the linker, > > > such as "make ARCH=arm64 install". > > > > > > Recently, the Kbuild tree queued up a patch to avoid needless > > > compiler/linker flag evaluation. I beleive it is a good improvement > > > itself, but causing a false-positive warning for arm64 installation > > > in linux-next. (Thanks to Nathan for the report) > > > > > > Kconfig can test the linker capability just once, and store it in the > > > .config file. The build and installation steps that follow do not need > > > to test the liniker over again. > > > > > > Reported-by: Nathan Chancellor <nathan@kernel.org> > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > > --- > > > > > > I was not sure what the preferred CONFIG option name is. > > > Please suggest a one if you have a better idea. > > > > > > > > > arch/arm64/Kconfig | 3 +++ > > > arch/arm64/Makefile | 2 +- > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > Would you like this patch to go in via the arm64 tree or you will queue > > it via the kbuild tree? > > I applied this to linux-kbuild with Will's Ack.
Great, I'll cross it off my list. Thanks.
-- Catalin
| |