Messages in this thread | | | Subject | Re: [PATCH v3] coccinelle: misc: add swap script | From | Denis Efremov <> | Date | Sun, 28 Mar 2021 12:19:13 +0300 |
| |
Ping?
On 3/5/21 1:09 PM, Denis Efremov wrote: > Check for opencoded swap() implementation. > > Signed-off-by: Denis Efremov <efremov@linux.com> > --- > Changes in v2: > - additional patch rule to drop excessive {} > - fix indentation in patch mode by anchoring ; > Changes in v3: > - Rule added for simple (without var init) swap highlighting in !patch mode > - "depends on patch && (rpvar || rp)" fixed > > scripts/coccinelle/misc/swap.cocci | 122 +++++++++++++++++++++++++++++ > 1 file changed, 122 insertions(+) > create mode 100644 scripts/coccinelle/misc/swap.cocci > > diff --git a/scripts/coccinelle/misc/swap.cocci b/scripts/coccinelle/misc/swap.cocci > new file mode 100644 > index 000000000000..c5e71b7ef7f5 > --- /dev/null > +++ b/scripts/coccinelle/misc/swap.cocci > @@ -0,0 +1,122 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Check for opencoded swap() implementation. > +/// > +// Confidence: High > +// Copyright: (C) 2021 Denis Efremov ISPRAS > +// Options: --no-includes --include-headers > +// > +// Keywords: swap > +// > + > +virtual patch > +virtual org > +virtual report > +virtual context > + > +@rvar depends on !patch@ > +identifier tmp; > +expression a, b; > +type T; > +position p; > +@@ > + > +( > +* T tmp; > +| > +* T tmp = 0; > +| > +* T *tmp = NULL; > +) > +... when != tmp > +* tmp = a; > +* a = b;@p > +* b = tmp; > +... when != tmp > + > +@r depends on !patch@ > +identifier tmp; > +expression a, b; > +position p != rvar.p; > +@@ > + > +* tmp = a; > +* a = b;@p > +* b = tmp; > + > +@rpvar depends on patch@ > +identifier tmp; > +expression a, b; > +type T; > +@@ > + > +( > +- T tmp; > +| > +- T tmp = 0; > +| > +- T *tmp = NULL; > +) > +... when != tmp > +- tmp = a; > +- a = b; > +- b = tmp > ++ swap(a, b) > + ; > +... when != tmp > + > +@rp depends on patch@ > +identifier tmp; > +expression a, b; > +@@ > + > +- tmp = a; > +- a = b; > +- b = tmp > ++ swap(a, b) > + ; > + > +@depends on patch && (rpvar || rp)@ > +@@ > + > +( > + for (...;...;...) > +- { > + swap(...); > +- } > +| > + while (...) > +- { > + swap(...); > +- } > +| > + if (...) > +- { > + swap(...); > +- } > +) > + > + > +@script:python depends on report@ > +p << r.p; > +@@ > + > +coccilib.report.print_report(p[0], "WARNING opportunity for swap()") > + > +@script:python depends on org@ > +p << r.p; > +@@ > + > +coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") > + > +@script:python depends on report@ > +p << rvar.p; > +@@ > + > +coccilib.report.print_report(p[0], "WARNING opportunity for swap()") > + > +@script:python depends on org@ > +p << rvar.p; > +@@ > + > +coccilib.org.print_todo(p[0], "WARNING opportunity for swap()") >
| |