Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sun, 28 Mar 2021 10:45:11 +0200 | Subject | Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS |
| |
Hi Julian,
On Sun, Mar 28, 2021 at 6:14 AM Julian Braha <julianbraha@gmail.com> wrote: > When LATENCYTOP is enabled and ARCH_WANT_FRAME_POINTERS > is disabled, Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for FRAME_POINTER > Depends on [n]: DEBUG_KERNEL [=y] && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS [=n] || MCOUNT [=n] > Selected by [y]: > - LATENCYTOP [=y] && DEBUG_KERNEL [=y] && STACKTRACE_SUPPORT [=y] && PROC_FS [=y] && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86 > > Depending on ARCH_WANT_FRAME_POINTERS causes a > recursive dependency error. > ARCH_WANT_FRAME_POINTERS is to be selected by the architecture, > and is not supposed to be overridden by other config options. > > Signed-off-by: Julian Braha <julianbraha@gmail.com>
Thanks for your patch!
> --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1665,7 +1665,7 @@ config LATENCYTOP > depends on DEBUG_KERNEL > depends on STACKTRACE_SUPPORT > depends on PROC_FS > - select FRAME_POINTER if !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86 > + select FRAME_POINTER if MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86
s/select/depends on/?
> select KALLSYMS > select KALLSYMS_ALL > select STACKTRACE
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |