lkml.org 
[lkml]   [2021]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/3] iio: adc: ad7923: use device-managed function for triggered buffer
    Converts the iio_triggered_buffer_setup() call to its device-managed
    counterpart.
    With this, the error handling routine in the ad7923_probe() function
    becomes unnecessary as well as the iio_triggered_buffer_cleanup() call.

    Signed-off-by: Lucas Stankus <lucas.p.stankus@gmail.com>
    ---
    drivers/iio/adc/ad7923.c | 15 +++------------
    1 file changed, 3 insertions(+), 12 deletions(-)

    diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
    index 3418ef6f0857..d07eaf3111ed 100644
    --- a/drivers/iio/adc/ad7923.c
    +++ b/drivers/iio/adc/ad7923.c
    @@ -351,20 +351,12 @@ static int ad7923_probe(struct spi_device *spi)
    if (ret)
    return ret;

    - ret = iio_triggered_buffer_setup(indio_dev, NULL,
    - &ad7923_trigger_handler, NULL);
    + ret = devm_iio_triggered_buffer_setup(&spi->dev, indio_dev, NULL,
    + &ad7923_trigger_handler, NULL);
    if (ret)
    return ret;

    - ret = iio_device_register(indio_dev);
    - if (ret)
    - goto error_cleanup_ring;
    -
    - return 0;
    -
    -error_cleanup_ring:
    - iio_triggered_buffer_cleanup(indio_dev);
    - return ret;
    + return iio_device_register(indio_dev);
    }

    static int ad7923_remove(struct spi_device *spi)
    @@ -372,7 +364,6 @@ static int ad7923_remove(struct spi_device *spi)
    struct iio_dev *indio_dev = spi_get_drvdata(spi);

    iio_device_unregister(indio_dev);
    - iio_triggered_buffer_cleanup(indio_dev);

    return 0;
    }
    --
    2.31.0
    \
     
     \ /
      Last update: 2021-03-28 23:47    [W:6.770 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site