lkml.org 
[lkml]   [2021]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs
    Am Thu, 18 Mar 2021 12:38:53 +0100
    schrieb "Enrico Weigelt, metux IT consult" <lkml@metux.net>:

    > On 15.03.21 12:19, Pavel Machek wrote:
    >
    > > But I still don't like the naming. simantic-ipc: prefix is
    > > useless. Having 6 status leds is not good, either.
    >
    > Do we have some standard naming policy those kinds of LEDs ?

    There is include/dt-bindings/leds/common.h with LED_FUNCTION_*

    > In this case, they seem to be assigned to certain specific functions
    > (by physical labels on the box), so IMHO the LED names should reflect
    > that in some ways.

    The choice for "status" was because of

    >> /* Miscelleaus functions. Use functions above if you can. */

    And those known names do not really come with an explanation of their
    meaning. Names like "bluetooth" seem obvious, but "activity" or
    "indicator" leave a lot of room for speculation.

    The choice in numbers was inspired by labels on the box, which i wanted
    to reflect in some way.

    Henning

    > There're other cases (eg. apu board familiy) that just have several
    > front panel leds w/o any dedication, so we can just count them up.
    >
    >
    > --mtx
    >

    \
     
     \ /
      Last update: 2021-03-27 10:53    [W:3.002 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site