Messages in this thread | | | Date | Fri, 26 Mar 2021 12:50:15 -0300 | Subject | Re: [PATCH V2 3/5] tools/perf: Add powerpc support for PERF_SAMPLE_WEIGHT_STRUCT | From | Arnaldo <> |
| |
On March 26, 2021 12:23:04 PM GMT-03:00, Athira Rajeev <atrajeev@linux.vnet.ibm.com> wrote: > > >On 25-Mar-2021, at 1:13 AM, Jiri Olsa <jolsa@redhat.com> wrote: > >On Mon, Mar 22, 2021 at 10:57:25AM -0400, Athira Rajeev wrote: > >Add arch specific arch_evsel__set_sample_weight() to set the new >sample type for powerpc. > >Add arch specific arch_perf_parse_sample_weight() to store the >sample->weight values depending on the sample type applied. >if the new sample type (PERF_SAMPLE_WEIGHT_STRUCT) is applied, >store only the lower 32 bits to sample->weight. If sample type >is 'PERF_SAMPLE_WEIGHT', store the full 64-bit to sample->weight. > >Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> >--- >tools/perf/arch/powerpc/util/Build | 2 ++ >tools/perf/arch/powerpc/util/event.c | 32 >++++++++++++++++++++++++++++++++ >tools/perf/arch/powerpc/util/evsel.c | 8 ++++++++ >3 files changed, 42 insertions(+) >create mode 100644 tools/perf/arch/powerpc/util/event.c >create mode 100644 tools/perf/arch/powerpc/util/evsel.c > >diff --git a/tools/perf/arch/powerpc/util/Build >b/tools/perf/arch/powerpc/util/Build >index b7945e5a543b..8a79c4126e5b 100644 >--- a/tools/perf/arch/powerpc/util/Build >+++ b/tools/perf/arch/powerpc/util/Build >@@ -4,6 +4,8 @@ perf-y += kvm-stat.o >perf-y += perf_regs.o >perf-y += mem-events.o >perf-y += sym-handling.o >+perf-y += evsel.o >+perf-y += event.o > >perf-$(CONFIG_DWARF) += dwarf-regs.o >perf-$(CONFIG_DWARF) += skip-callchain-idx.o >diff --git a/tools/perf/arch/powerpc/util/event.c >b/tools/perf/arch/powerpc/util/event.c >new file mode 100644 >index 000000000000..f49d32c2c8ae >--- /dev/null >+++ b/tools/perf/arch/powerpc/util/event.c >@@ -0,0 +1,32 @@ >+// SPDX-License-Identifier: GPL-2.0 >+#include <linux/types.h> >+#include <linux/string.h> >+#include <linux/zalloc.h> >+ >+#include "../../../util/event.h" >+#include "../../../util/synthetic-events.h" >+#include "../../../util/machine.h" >+#include "../../../util/tool.h" >+#include "../../../util/map.h" >+#include "../../../util/debug.h" > > >nit, just #include "utils/...h" should work no? > >other than that, the patchset looks ok to me > >Acked-by: Jiri Olsa <jolsa@redhat.com> > > > >Hi Jiri, Arnaldo > >Thanks for reviewing the patch set. >I checked that, just using "utils/...h" also works. >Below is the change which I verified. Since the patches are presently >merged in >https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf/core, > >can you please suggest how can we go about this change ?
I'll fix it up here,
Thanks for the patch.
- Arnaldo
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.
| |