Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 26 Mar 2021 16:12:28 +0100 | Subject | Re: [PATCH 4/4] exec: move the call to getname_flags into do_execveat |
| |
On Fri, Mar 26, 2021 at 3:38 PM Christoph Hellwig <hch@lst.de> wrote: > > Remove the duplicated copying of the pathname into the common helper. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks correct, but
> -static int do_execveat(int fd, struct filename *filename, > +static int do_execveat(int fd, const char __user *pathname, > const char __user *const __user *argv, > const char __user *const __user *envp, int flags)
Maybe rename this to ksys_execveat() for consistency now? I think that is the current trend for functions that are essentially just the syscall.
With or without that change
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
| |