lkml.org 
[lkml]   [2021]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 14/15] staging: rtl8723bs: put parentheses on macros with complex values in include/sta_info.h
    Date
    From: Fabio Aiuto 
    > Sent: 26 March 2021 09:09
    >
    > fix the following checkpatch warnings:
    >
    > ERROR: Macros with complex values should be enclosed in parentheses
    > 284: FILE: drivers/staging/rtl8723bs/include/sta_info.h:284:
    > +#define STA_RX_PKTS_ARG(sta) \
    > --
    > ERROR: Macros with complex values should be enclosed in parentheses
    > 289: FILE: drivers/staging/rtl8723bs/include/sta_info.h:289:
    > +#define STA_LAST_RX_PKTS_ARG(sta) \
    > --
    > ERROR: Macros with complex values should be enclosed in parentheses
    > 294: FILE: drivers/staging/rtl8723bs/include/sta_info.h:294:
    > +#define STA_RX_PKTS_DIFF_ARG(sta) \
    >
    > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
    > ---
    > drivers/staging/rtl8723bs/include/sta_info.h | 12 ++++++------
    > 1 file changed, 6 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/staging/rtl8723bs/include/sta_info.h
    > b/drivers/staging/rtl8723bs/include/sta_info.h
    > index abde3e3df988..1cdf93ec3b66 100644
    > --- a/drivers/staging/rtl8723bs/include/sta_info.h
    > +++ b/drivers/staging/rtl8723bs/include/sta_info.h
    > @@ -282,19 +282,19 @@ struct sta_info {
    > } while (0)
    >
    > #define STA_RX_PKTS_ARG(sta) \
    > - sta->sta_stats.rx_mgnt_pkts \
    > + (sta->sta_stats.rx_mgnt_pkts \
    > , sta->sta_stats.rx_ctrl_pkts \
    > - , sta->sta_stats.rx_data_pkts
    > + , sta->sta_stats.rx_data_pkts)

    That doesn't look right at all.
    You've changed what is (probably) a list of arguments to a function
    into a comma operator list.

    David

    -
    Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
    Registration No: 1397386 (Wales)

    \
     
     \ /
      Last update: 2021-03-26 14:40    [W:4.072 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site