Messages in this thread | | | Subject | Re: [PATCH v2 6/9] debugfs: Implement debugfs_create_str() | From | Rasmus Villemoes <> | Date | Fri, 26 Mar 2021 14:10:41 +0100 |
| |
On 26/03/2021 13.57, Greg KH wrote: > On Fri, Mar 26, 2021 at 01:53:59PM +0100, Rasmus Villemoes wrote: >> On 26/03/2021 12.38, Peter Zijlstra wrote: >> >>> Implement debugfs_create_str() to easily display names and such in >>> debugfs. >> >> Patches 7-9 don't seem to add any users of this. What's it for precisely? > > It's used in patch 7, look close :)
Ah, macrology. But the write capability doesn't seem used, and I (still) fail to see how that could be useful.
>>> +EXPORT_SYMBOL_GPL(debugfs_read_file_str); >> >> Why? > > Because there is a user of it? Yes, it's not in a module, but to make > it easy, might as well export it now.
No, I was asking why the individual read (and write) methods would need to be exported. They have even less reason then debugfs_create_str() - which I also think shouldn't be exported until a modular user shows up.
Rasmus
| |