lkml.org 
[lkml]   [2021]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v4 2/4] dt-bindings: power: rockchip: Convert to json-schema
    Date
    Am Mittwoch, 24. März 2021, 11:32:42 CET schrieb Enric Balletbo i Serra:
    >
    > On 24/3/21 11:25, Enric Balletbo i Serra wrote:
    > > Hi Elaine,
    > >
    > > On 24/3/21 11:18, elaine.zhang wrote:
    > >> Hi, Enric
    > >>
    > >> 在 2021/3/24 下午5:56, Enric Balletbo i Serra 写道:
    > >>> Hi Elaine,
    > >>>
    > >>> This is not the exact version I sent, and you reintroduced a "problem" that were
    > >>> already solved/discussed on previous versions. See below:
    > >>>
    > >>> On 24/3/21 8:16, Elaine Zhang wrote:
    > >>>> Convert the soc/rockchip/power_domain.txt binding document to
    > >>>> json-schema and move to the power bindings directory.
    > >>>>
    > >>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    > >>> If you do significant is a good practice shortly describe them within [] here.
    > >>>
    > >>>> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
    > >>> Note that my last version already had the
    > >>>
    > >>> Reviewed-by: Rob Herring <robh@kernel.org>
    > >>>
    > >>> Which should be fine for merging (with probably only minor changes) and you
    > >>> could maintain if you don't do significant changes, but that's not the case, as
    > >>> I said, you are reintroducing one problem. Please review the comments already
    > >>> received on this patchset or similar patchsets to avoid this.
    > >>>
    > >>>> ---
    > >>>> .../power/rockchip,power-controller.yaml | 284 ++++++++++++++++++
    > >>>> .../bindings/soc/rockchip/power_domain.txt | 136 ---------
    > >>>> 2 files changed, 284 insertions(+), 136 deletions(-)
    > >>>> create mode 100644
    > >>>> Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
    > >>>> delete mode 100644
    > >>>> Documentation/devicetree/bindings/soc/rockchip/power_domain.txt
    > >>>>
    > >>>> diff --git
    > >>>> a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
    > >>>> b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
    > >>>> new file mode 100644
    > >>>> index 000000000000..a220322c5139
    > >>>> --- /dev/null
    > >>>> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
    > >>>> @@ -0,0 +1,284 @@
    > >>>> +# SPDX-License-Identifier: GPL-2.0-only
    > >>>> +%YAML 1.2
    > >>>> +---
    > >>>> +$id: http://devicetree.org/schemas/power/rockchip,power-controller.yaml#
    > >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > >>>> +
    > >>>> +title: Rockchip Power Domains
    > >>>> +
    > >>>> +maintainers:
    > >>>> + - Elaine Zhang <zhangqing@rock-chips.com>
    > >>>> + - Rob Herring <robh+dt@kernel.org>
    > >>> Up to Rob, but I don't think Rob would like to be the maintainer. I think you
    > >>> can only include yourself and Heiko.
    > >>>
    > >>>
    > >>>> + - Heiko Stuebner <heiko@sntech.de>
    > >>>> +
    > >>>> +description: |
    > >>>> + Rockchip processors include support for multiple power domains which can be
    > >>>> + powered up/down by software based on different application scenarios to
    > >>>> save power.
    > >>>> +
    > >>>> + Power domains contained within power-controller node are generic power domain
    > >>>> + providers documented in
    > >>>> Documentation/devicetree/bindings/power/power-domain.yaml.
    > >>>> +
    > >>>> + IP cores belonging to a power domain should contain a "power-domains"
    > >>>> + property that is a phandle for the power domain node representing the domain.
    > >>>> +
    > >>>> +properties:
    > >>>> + $nodename:
    > >>>> + const: power-controller
    > >>>> +
    > >>>> + compatible:
    > >>>> + enum:
    > >>>> + - rockchip,px30-power-controller
    > >>>> + - rockchip,rk3036-power-controller
    > >>>> + - rockchip,rk3066-power-controller
    > >>>> + - rockchip,rk3128-power-controller
    > >>>> + - rockchip,rk3188-power-controller
    > >>>> + - rockchip,rk3228-power-controller
    > >>>> + - rockchip,rk3288-power-controller
    > >>>> + - rockchip,rk3328-power-controller
    > >>>> + - rockchip,rk3366-power-controller
    > >>>> + - rockchip,rk3368-power-controller
    > >>>> + - rockchip,rk3399-power-controller
    > >>>> +
    > >>>> + "#power-domain-cells":
    > >>>> + const: 1
    > >>>> +
    > >>>> + "#address-cells":
    > >>>> + const: 1
    > >>>> +
    > >>>> + "#size-cells":
    > >>>> + const: 0
    > >>>> +
    > >>>> +patternProperties:
    > >>>> + "^pd_[0-9a-z_]{2,10}@[0-9a-f]+$":
    > >>>> + type: object
    > >>>> + description: |
    > >>>> + Represents the power domains within the power controller node as
    > >>>> documented
    > >>>> + in Documentation/devicetree/bindings/power/power-domain.yaml.
    > >>>> +
    > >>> The node names must be generic, as this is power-domain must be in the form:
    > >>>
    > >>> +patternProperties:
    > >>> + "^power-domain@[0-9a-f]+$":
    > >> In this way, dtbs_check cannot be passed, and all the usage methods in dts of
    > >> Rockchip need to be corrected, which I think is a bigger change.
    > >
    > > Well, the problem is in the Rockchip dtbs, so needs to be fixed there. The
    > > bindings must describe hardware in a generic way, not describe the actual dtbs
    > > to not report errors.
    > >
    >
    > FWIW I remember I did something regarding this but never sent to upstream, feel
    > free to pick if you find useful.
    >
    > *
    > https://gitlab.collabora.com/eballetbo/linux/-/commit/12499f223e3d33602449b9102404fe573fb804f5
    > *
    > https://gitlab.collabora.com/eballetbo/linux/-/commit/12499f223e3d33602449b9102404fe573fb804f5
    > *
    > https://gitlab.collabora.com/eballetbo/linux/-/commit/492bf2213c341152a1c2423242c5634b9e53ff27

    looks good that way. I did look at the power-domain driver and
    we're (of course) not doing anything with the name in front of the @ :-) .

    So I'd be happy to get these.

    Heiko


    \
     
     \ /
      Last update: 2021-03-24 14:33    [W:3.261 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site