lkml.org 
[lkml]   [2021]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/5] iommu/vt-d: Remove SVM_FLAG_PRIVATE_PASID
    From
    Date
    Hi Christoph,

    On 3/24/21 1:33 AM, Christoph Hellwig wrote:
    > On Tue, Mar 23, 2021 at 09:05:58AM +0800, Lu Baolu wrote:
    >> The SVM_FLAG_PRIVATE_PASID has never been referenced in the tree, and
    >> there's no plan to have anything to use it. So cleanup it.
    >>
    >> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
    >
    > Looks good,
    >
    > Reviewed-by: Christoph Hellwig <hch@lst.de>

    Thank you!

    >
    > But can we take this a little further? SVM_FLAG_GUEST_PASID is unused
    > as well. SVM_FLAG_GUEST_MODE is only used in drivers/iommu/intel/svm.c,
    > and SVM_FLAG_SUPERVISOR_MODE is actually used as an API flag to
    > iommu_sva_bind_device. So IMHO the latter should be elevated to an
    > IOMMU API level flag, and then include/linux/intel-svm.h can go away
    > entirely or at least be moved to drivers/iommu/intel/.
    >

    Sure. I will consider it and make it in separated patches.

    Best regards,
    baolu

    \
     
     \ /
      Last update: 2021-03-24 08:37    [W:3.011 / U:0.576 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site