Messages in this thread | | | Subject | Re: [PATCH v3] phy: zynqmp: Handle the clock enable/disable properly | From | Michal Simek <> | Date | Wed, 24 Mar 2021 08:17:21 +0100 |
| |
On 3/23/21 3:19 PM, Manish Narani wrote: > The current driver is not handling the clock enable/disable operations > properly. The clocks need to be handled correctly by enabling or > disabling at appropriate places. This patch adds code to handle the > same. > > Signed-off-by: Manish Narani <manish.narani@xilinx.com> > --- > drivers/phy/xilinx/phy-zynqmp.c | 57 ++++++++++++++++++++++++++++++++++++----- > 1 file changed, 50 insertions(+), 7 deletions(-) > > diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c > index 2b65f84..69492a5 100644 > --- a/drivers/phy/xilinx/phy-zynqmp.c > +++ b/drivers/phy/xilinx/phy-zynqmp.c > @@ -219,6 +219,7 @@ struct xpsgtr_dev { > struct mutex gtr_mutex; /* mutex for locking */ > struct xpsgtr_phy phys[NUM_LANES]; > const struct xpsgtr_ssc *refclk_sscs[NUM_LANES]; > + struct clk *clk[NUM_LANES];
Please also document this property.
./scripts/kernel-doc -man -v drivers/phy/xilinx/phy-zynqmp.c >/dev/null drivers/phy/xilinx/phy-zynqmp.c:170: info: Scanning doc for struct xpsgtr_ssc drivers/phy/xilinx/phy-zynqmp.c:184: info: Scanning doc for struct xpsgtr_phy drivers/phy/xilinx/phy-zynqmp.c:204: info: Scanning doc for struct xpsgtr_dev drivers/phy/xilinx/phy-zynqmp.c:226: warning: Function parameter or member 'clk' not described in 'xpsgtr_dev' 1 warnings
Thanks, Michal
| |