lkml.org 
[lkml]   [2021]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 02/28] mm: Add an unlock function for PG_private_2/PG_fscache
Date
David Howells <dhowells@redhat.com> wrote:

> > > - wait_on_page_writeback(page);
> > > + if (wait_on_page_writeback_killable(page) < 0)
> > > + return VM_FAULT_RETRY | VM_FAULT_LOCKED;
> >
> > You forgot to unlock the page.
>
> Do I need to? Doesn't VM_FAULT_LOCKED indicate that to the caller? Or is it
> impermissible to do it like that?

Looks like, yes, I do need to. VM_FAULT_LOCKED is ignored if RETRY is given.

David

\
 
 \ /
  Last update: 2021-03-23 23:07    [W:0.199 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site