Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v4 02/28] mm: Add an unlock function for PG_private_2/PG_fscache | Date | Tue, 23 Mar 2021 22:06:04 +0000 |
| |
David Howells <dhowells@redhat.com> wrote:
> > > - wait_on_page_writeback(page); > > > + if (wait_on_page_writeback_killable(page) < 0) > > > + return VM_FAULT_RETRY | VM_FAULT_LOCKED; > > > > You forgot to unlock the page. > > Do I need to? Doesn't VM_FAULT_LOCKED indicate that to the caller? Or is it > impermissible to do it like that?
Looks like, yes, I do need to. VM_FAULT_LOCKED is ignored if RETRY is given.
David
| |