lkml.org 
[lkml]   [2021]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 03/13] PCI: xilinx: Convert to MSI domains
    From
    Date
    Hi,

    On 3/22/21 1:21 PM, Lorenzo Pieralisi wrote:
    > On Thu, Feb 25, 2021 at 03:10:13PM +0000, Marc Zyngier wrote:
    >> In anticipation of the removal of the msi_controller structure, convert
    >> the ancient xilinx host controller driver to MSI domains.
    >>
    >> We end-up with the usual two domain structure, the top one being a
    >> generic PCI/MSI domain, the bottom one being xilinx-specific and handling
    >> the actual HW interrupt allocation.
    >>
    >> This allows us to fix some of the most appaling MSI programming, where
    >> the message programmed in the device is the virtual IRQ number instead
    >> of the allocated vector number. The allocator is also made safe with
    >> a mutex. This should allow support for MultiMSI, but I decided not to
    >> even try, since I cannot test it.
    >>
    >> Also take the opportunity to get rid of the cargo-culted memory allocation
    >> for the MSI capture address. *ANY* sufficiently aligned address should
    >> be good enough, so use the physical address of the xilinx_pcie_host
    >> structure instead.
    >>
    >> Signed-off-by: Marc Zyngier <maz@kernel.org>
    >> ---
    >> drivers/pci/controller/Kconfig | 2 +-
    >> drivers/pci/controller/pcie-xilinx.c | 238 +++++++++++----------------
    >> 2 files changed, 96 insertions(+), 144 deletions(-)
    >
    > Michal,
    >
    > can you please test these changes or make sure someone does and report
    > back on the mailing list please ?
    >
    > I would like to merge this series for v5.13.

    I got just private response (not sure why) from Bharat March 5 that
    changes are fine.
    It means go ahead with it.

    Thanks,
    Michal

    \
     
     \ /
      Last update: 2021-03-22 13:38    [W:2.994 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site