lkml.org 
[lkml]   [2021]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 066/120] scsi: ufs: ufs-mediatek: Correct operator & -> &&
    Date
    From: dongjian <dongjian@yulong.com>

    commit 0fdc7d5d8f3719950478cca452cf7f0f1355be10 upstream.

    The "lpm" and "->enabled" are all boolean. We should be using &&
    rather than the bit operator.

    Link: https://lore.kernel.org/r/1615896915-148864-1-git-send-email-dj0227@163.com
    Fixes: 488edafb1120 ("scsi: ufs-mediatek: Introduce low-power mode for device power supply")
    Reviewed-by: Avri Altman <avri.altman@wdc.com>
    Signed-off-by: dongjian <dongjian@yulong.com>
    Signed-off-by: Yue Hu <huyue2@yulong.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/ufs/ufs-mediatek.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/ufs/ufs-mediatek.c
    +++ b/drivers/scsi/ufs/ufs-mediatek.c
    @@ -911,7 +911,7 @@ static void ufs_mtk_vreg_set_lpm(struct
    if (!hba->vreg_info.vccq2 || !hba->vreg_info.vcc)
    return;

    - if (lpm & !hba->vreg_info.vcc->enabled)
    + if (lpm && !hba->vreg_info.vcc->enabled)
    regulator_set_mode(hba->vreg_info.vccq2->reg,
    REGULATOR_MODE_IDLE);
    else if (!lpm)

    \
     
     \ /
      Last update: 2021-03-22 13:36    [W:4.082 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site