lkml.org 
[lkml]   [2021]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 012/120] s390/vtime: fix increased steal time accounting
    Date
    From: Gerald Schaefer <gerald.schaefer@linux.ibm.com>

    commit d54cb7d54877d529bc1e0e1f47a3dd082f73add3 upstream.

    Commit 152e9b8676c6e ("s390/vtime: steal time exponential moving average")
    inadvertently changed the input value for account_steal_time() from
    "cputime_to_nsecs(steal)" to just "steal", resulting in broken increased
    steal time accounting.

    Fix this by changing it back to "cputime_to_nsecs(steal)".

    Fixes: 152e9b8676c6e ("s390/vtime: steal time exponential moving average")
    Cc: <stable@vger.kernel.org> # 5.1
    Reported-by: Sabine Forkel <sabine.forkel@de.ibm.com>
    Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
    Signed-off-by: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
    Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/s390/kernel/vtime.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/s390/kernel/vtime.c
    +++ b/arch/s390/kernel/vtime.c
    @@ -217,7 +217,7 @@ void vtime_flush(struct task_struct *tsk
    avg_steal = S390_lowcore.avg_steal_timer / 2;
    if ((s64) steal > 0) {
    S390_lowcore.steal_timer = 0;
    - account_steal_time(steal);
    + account_steal_time(cputime_to_nsecs(steal));
    avg_steal += steal;
    }
    S390_lowcore.avg_steal_timer = avg_steal;

    \
     
     \ /
      Last update: 2021-03-22 13:31    [W:5.417 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site