| Date | Tue, 2 Mar 2021 17:25:42 -0500 | From | Steven Rostedt <> | Subject | Re: [RFC PATCH v5 19/19] virtio/vsock: update trace event for SEQPACKET |
| |
On Thu, 18 Feb 2021 08:42:15 +0300 Arseny Krasnov <arseny.krasnov@kaspersky.com> wrote:
Not sure if this was pulled in yet, but I do have a small issue with this patch.
> @@ -69,14 +82,19 @@ TRACE_EVENT(virtio_transport_alloc_pkt, > __entry->type = type; > __entry->op = op; > __entry->flags = flags; > + __entry->msg_len = msg_len; > + __entry->msg_cnt = msg_cnt; > ), > - TP_printk("%u:%u -> %u:%u len=%u type=%s op=%s flags=%#x", > + TP_printk("%u:%u -> %u:%u len=%u type=%s op=%s flags=%#x " > + "msg_len=%u msg_cnt=%u",
It's considered poor formatting to split strings like the above. This is one of the exceptions for the 80 character limit. Do not break strings just to keep it within 80 characters.
-- Steve
> __entry->src_cid, __entry->src_port, > __entry->dst_cid, __entry->dst_port, > __entry->len, > show_type(__entry->type), > show_op(__entry->op), > - __entry->flags) > + __entry->flags, > + __entry->msg_len, > + __entry->msg_cnt) > );
|