lkml.org 
[lkml]   [2021]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 32/44] tty: xtensa/iss, setup the timer statically
    Date
    Use DEFINE_TIMER and avoid runtime initialization of the serial_timer.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Chris Zankel <chris@zankel.net>
    Cc: Max Filippov <jcmvbkbc@gmail.com>
    Cc: linux-xtensa@linux-xtensa.org
    ---
    arch/xtensa/platforms/iss/console.c | 11 ++++-------
    1 file changed, 4 insertions(+), 7 deletions(-)

    diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
    index 3b89d9ceb06a..8ea261b8c022 100644
    --- a/arch/xtensa/platforms/iss/console.c
    +++ b/arch/xtensa/platforms/iss/console.c
    @@ -31,21 +31,18 @@
    #define SERIAL_MAX_NUM_LINES 1
    #define SERIAL_TIMER_VALUE (HZ / 10)

    +static void rs_poll(struct timer_list *);
    +
    static struct tty_driver *serial_driver;
    static struct tty_port serial_port;
    -static struct timer_list serial_timer;
    -
    +static DEFINE_TIMER(serial_timer, rs_poll);
    static DEFINE_SPINLOCK(timer_lock);

    -static void rs_poll(struct timer_list *);
    -
    static int rs_open(struct tty_struct *tty, struct file * filp)
    {
    spin_lock_bh(&timer_lock);
    - if (tty->count == 1) {
    - timer_setup(&serial_timer, rs_poll, 0);
    + if (tty->count == 1)
    mod_timer(&serial_timer, jiffies + SERIAL_TIMER_VALUE);
    - }
    spin_unlock_bh(&timer_lock);

    return 0;
    --
    2.30.1
    \
     
     \ /
      Last update: 2021-03-02 16:10    [W:4.136 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site