Messages in this thread | | | From | Jens Wiklander <> | Date | Fri, 19 Mar 2021 08:00:22 +0100 | Subject | Re: [PATCH v2 1/2] optee: fix tee out of memory failure seen during kexec reboot |
| |
On Tue, Mar 16, 2021 at 2:21 PM Allen Pais <apais@linux.microsoft.com> wrote: > > > > >> > >> [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed > >> [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22 > >> > >> tee_shm_release() is not invoked on dma shm buffer. > >> > >> Implement .shutdown() method to handle the release of the buffers > >> correctly. > >> > >> More info: > >> https://github.com/OP-TEE/optee_os/issues/3637 > >> > >> Signed-off-by: Allen Pais <apais@linux.microsoft.com> > >> --- > >> drivers/tee/optee/core.c | 20 ++++++++++++++++++++ > >> 1 file changed, 20 insertions(+) > > > > This looks good to me. Do you have a practical way of testing this on > > QEMU for instance? > > > > Jens, > > I could not reproduce nor create a setup using QEMU, I could only > do it on a real h/w. > > I have extensively tested the fix and I don't see any issues.
I did a few test runs too, seems OK.
Thanks, Jens
| |