Messages in this thread | | | Subject | Re: [PATCH v6 05/17] media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL | From | Hans Verkuil <> | Date | Thu, 18 Mar 2021 08:16:29 +0100 |
| |
On 17/03/2021 17:44, Ricardo Ribalda wrote: > The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is > written. > > Cc: Mike Isely <isely@pobox.com> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Thanks!
Hans
> --- > drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c > index 9657c1883311..c04ab7258d64 100644 > --- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c > +++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c > @@ -640,10 +640,6 @@ static int pvr2_s_ext_ctrls(struct file *file, void *priv, > unsigned int idx; > int ret; > > - /* Default value cannot be changed */ > - if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL) > - return -EINVAL; > - > ret = 0; > for (idx = 0; idx < ctls->count; idx++) { > ctrl = ctls->controls + idx; >
| |